Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correct v1 joint limits #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

methylDragon
Copy link
Contributor

I found that the joint limits specified in the V1 URDF are a lot more conservative than the arm allows, which causes issues with planning. This PR fixes that.

@brentyi
Copy link
Collaborator

brentyi commented Jun 1, 2019

Hm -- what kind of planning issues were you seeing, and have you tested these new numbers thoroughly?

We originally made the joint limits conservative to (a) prevent the joints from hyperextending and (b) prevent plans being made past our "soft stops" (we apply a reverse torque when a joint is too close to its limit).

Not sure if these are actual issues, but I'm a bit worried about the consequences of making these joint limits more generous than our softstop limits, which are currently in the robot parameter yaml files in blue_bringup (though they should probably be calculated from values read from the URDF).

@methylDragon
Copy link
Contributor Author

methylDragon commented Jun 1, 2019

Oh, the conservative joint limits just makes moveit take a lot of weird trajectories as opposed to when they're more accurate.

Also, since my helper pickup ready position commander script sets the joint positions beyond those limits, moveit refuses to plan since it thinks the arm is in an invalid state.

I didn't take into account the soft stops since the moveit implementation is using a ros_control controller instead though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants