Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockchain): Enforce unused fields in Eth1Data #2382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shotes
Copy link
Contributor

@shotes shotes commented Jan 20, 2025

Ensure that the unused fields are unused with validation:

  • This ensures that the unused fields cannot change the HashTreeRoot of the BeaconBlock
  • Better supports compatibility with future updates to the protocol, ensuring that these fields are unused at previous iterations.

Edit: This likely won't make it into the mainnet release. If that is the case, this PR will have to be reworked with extra forking logic.

@shotes shotes requested a review from a team as a code owner January 20, 2025 04:58
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 31.25%. Comparing base (5dfa536) to head (6cbe5fc).

Files with missing lines Patch % Lines
consensus-types/types/eth1data.go 31.81% 10 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
- Coverage   31.26%   31.25%   -0.01%     
==========================================
  Files         346      346              
  Lines       15434    15455      +21     
  Branches       20       20              
==========================================
+ Hits         4825     4831       +6     
- Misses      10272    10282      +10     
- Partials      337      342       +5     
Files with missing lines Coverage Δ
state-transition/core/state_processor_genesis.go 41.52% <100.00%> (ø)
consensus-types/types/eth1data.go 68.75% <31.81%> (-19.63%) ⬇️

@shotes shotes changed the title Enforce unused fields in Eth1Data chore(blockchain): Enforce unused fields in Eth1Data Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant