[DO NOT MERGE] working diff of latest changes against boonet #2335
+13,870
−11,016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timistically (#2240) Signed-off-by: nidhi-singh02 <[email protected]> Signed-off-by: Nidhi Singh <[email protected]>
) Co-authored-by: Giuseppe Cocomazzi <[email protected]>
I originally moved this to the chain package due to cyclic dependencies, but I only needed to do that for the ChainSpec type and not the others, so reverting that here.
We always call handleRPCError(err) on a non nil err so this has to be a false positive error reported by nilalawy.
Signed-off-by: Cal Bera <[email protected]> Co-authored-by: Cal Bera <[email protected]> Co-authored-by: Shota Ehrlich <[email protected]>
Signed-off-by: Cal Bera <[email protected]> Co-authored-by: aBear <[email protected]> Co-authored-by: Shota Ehrlich <[email protected]>
Co-authored-by: Alessandro Sforzin <[email protected]> Co-authored-by: Friðrik Ásmundsson <[email protected]>
Updated go.mod and go.sum to pull latest version of cometbft.
Co-authored-by: aBear <[email protected]>
…l verification (#2311) Co-authored-by: Alberto Benegiamo <[email protected]>
* feat: Detect if beacond was unsafely shutdown If we detect that it was previously had a unsaf shutdown we now log a warning including the process id (pid) of the application along with the time that pid started. * fix: make logger a required param to Registry * Move the shutdown detection to new shutdown service * fix: consensus failure in cometbft during shutdown + other improvements (#112) * Silence usage when returning error from start cmd * Explicitly wait for cometbft node to stop during shutdown * fix: conensus failure in cometbft during shutdown Now that we are handling SIGTERM signal to gracefully shutdown beacond, we sometime get a panic within cometbft with a "CONSENSUS FAILURE!" error due to us closing peppledb before cometbft could properly shutdown. After debugging, this is due to two issues: 1. We are stopping services in same order they were started. Instead we should stop them in the reverse order. 2. If a service returns an error from Stop() the registry will return that error and not call Close on the remaining services. This can cause data loss. This commit updates addresses these 2 issues. * Do not ignore errors in cometbft service when calling Stop() --------- Co-authored-by: aBear <[email protected]>
* fixed ErrAcceptedPayloadStatus handling * nit * fixed error handling for good
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
feat(cli): Add cli genesis set storage command
* chore(types): enforce eth1 withdrawal credentials to eth2 spec * lint * nit comments * explicit const * nit cleanup
…sis file (#135) * fix(cli): set-deposit-storage -- only modify slot0, slot1 in eth-genesis file * fix * lint
* fix(metrics): only report EL gas used in FinalizeBlock * make explicit in transaction.Context when to meter gas --------- Co-authored-by: aBear <[email protected]>
* feat: sign build artefacts Signed-off-by: gummy <[email protected]> * fix: remove pat Signed-off-by: gummy <[email protected]> * Update .github/workflows/release.yaml Signed-off-by: Cal Bera <[email protected]> --------- Signed-off-by: gummy <[email protected]> Signed-off-by: Cal Bera <[email protected]> Co-authored-by: Cal Bera <[email protected]>
…lock deposits (#142) * fix(state-transition): Correctly enforce local validation of beacon block deposits * lint cleanup * Update state-transition/core/validation_deposits_test.go Signed-off-by: Cal Bera <[email protected]> * nit clean for loop * nosec --------- Signed-off-by: Cal Bera <[email protected]>
feat(BeaconKit): getting to v1.0.0
fix(consensus): explicitly check consensus txs count
Co-authored-by: Alberto Benegiamo <[email protected]>
…ic. (#2364) Co-authored-by: Cal Bera <[email protected]>
…ics (#2369) Co-authored-by: aBear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.