Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method extraction cledithighlighter #1558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yakryder
Copy link

@yakryder yakryder commented Oct 9, 2019

Cleanup of #1556.

Comments dup'ed below:

Really simple stuff. For me this is a small improvement, but I'd be interested in some guidance on the intended file organization in general and the function that is currently called removeUnauthorizedSiblingNodesFrom specifically.

If this looks worse to you rather than better it's no problem :)

Replaces comments, follows example of `highlight/1` in same file
Replaces comments and follows example of `highlight/1` in same file
@yakryder yakryder force-pushed the method-extraction-cledithighlighter branch from 94e058c to 7bb112f Compare October 9, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant