fix: s3 in cluster scheme

bentoml · Jul 6, 2022 · c9af126 · c9af126
1 parent af6f648
commit c9af126
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/api-server/services/organization.go b/api-server/services/organization.go
@@ -416,6 +416,8 @@ func (s *organizationService) GetS3Config(ctx context.Context, org *models.Organ
 		scheme = "https"
 	}
 
+	inClusterScheme := scheme
+
 	if endpointInCluster == "" {
 		svcCli := cliset.CoreV1().Services(consts.KubeNamespaceYataiComponents)
 		var svc *corev1.Service
@@ -430,14 +432,15 @@ func (s *organizationService) GetS3Config(ctx context.Context, org *models.Organ
 			endpointInCluster = endpoint
 		} else {
 			endpointInCluster = fmt.Sprintf("%s.%s", svc.Name, svc.Namespace)
+			inClusterScheme = "http"
 		}
 	}
 
 	conf = &S3Config{
 		Endpoint:                    endpoint,
 		EndpointInCluster:           endpointInCluster,
 		EndpointWithScheme:          fmt.Sprintf("%s://%s", scheme, endpoint),
-		EndpointWithSchemeInCluster: fmt.Sprintf("%s://%s", scheme, endpointInCluster),
+		EndpointWithSchemeInCluster: fmt.Sprintf("%s://%s", inClusterScheme, endpointInCluster),
 		AccessKey:                   string(accessKey),
 		SecretKey:                   string(secretKey),
 		Secure:                      secure,