fix(cloud-client): consider httpcore timeout when getting status #4740

Haivilo · 2024-05-16T19:51:44Z

What does this PR address?

Fixes #(issue)

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

src/bentoml/_internal/cloud/deployment.py

For more information, see https://pre-commit.ci

Haivilo requested a review from a team as a code owner May 16, 2024 19:51

Haivilo requested review from sauyon and FogDong and removed request for a team May 16, 2024 19:51

frostming reviewed May 24, 2024

View reviewed changes

src/bentoml/_internal/cloud/deployment.py Outdated Show resolved Hide resolved

Haivilo and others added 3 commits June 5, 2024 21:07

fix(cloud-client): consider httpcore timeout when getting status

6397cfc

ci: auto fixes from pre-commit.ci

209c1e5

For more information, see https://pre-commit.ci

fix: use httpx error

1ab27ea

Haivilo force-pushed the fix-status-timeout branch from 17f7c79 to 1ab27ea Compare June 6, 2024 04:08

FogDong approved these changes Jun 6, 2024

View reviewed changes

aarnphm approved these changes Jun 12, 2024

View reviewed changes

aarnphm merged commit fe55d96 into bentoml:main Jun 14, 2024
42 checks passed