Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end to end testing example phantom opts #140

Open
ransomw opened this issue Jul 28, 2017 · 1 comment
Open

end to end testing example phantom opts #140

ransomw opened this issue Jul 28, 2017 · 1 comment

Comments

@ransomw
Copy link

ransomw commented Jul 28, 2017

i found it necessary to modify the End to end testing example from the wiki in order for phantom to make cors requests:

both --web-security=false and --local-to-remote-url-access=true are necessary to prevent a

XMLHttpRequest cannot load http://localhost:3333/demo/hello. Cross origin requests are not supported.

out of phantom.

it's possible to try it out with (do (reload-require) (run-doo-tests)) in a lein repl with the source linked above, toggling phantom opts between (do (reload-require) (run-doo-tests))ing in the repl.


i suppose an update might not be such a priority since other issues indicate that phantom is on the way out .. anyway, i wanted to get it documented here as an issue, even if the next update to the wiki includes chromium headless rather than phantom.

@MatthewDarling
Copy link
Contributor

Chrome Headless support is available starting with lein-doo version 0.1.8 :)

Should the linked tutorial (and others?) be updated to use it, rather than PhantomJS? Any volunteers to do so?

I seem to have permission to edit the wiki. Happy to do the edits if someone else writes the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants