-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test failing #114
Comments
@jmlsf Yes, a PR would be welcome. We can also drop phantom if there are better options? |
If we can get chrome-headless to work in travis, that is surely better. The problem here is that I need to install karma to use chrome-headless with lein-doo. I think I'll have to add a package.json to do so. |
Okay I got it to work. I'm don't have a lot of expertise, but the general sentiment seems to be that using chrome is better then using phantom. Seems logical that using a real browser is better than a mock. |
@r0man The unit tests are failing as we discussed. It appears to be because of phantomjs. This fix looks a bit ugly. See this issue:
bensu/doo#140
I tried it with karma & chrome-headless and the tests pass. I'll submit a PR if you want to try it out.
The text was updated successfully, but these errors were encountered: