Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization #87

Merged
merged 30 commits into from
Nov 2, 2024
Merged

Serialization #87

merged 30 commits into from
Nov 2, 2024

Conversation

benpollarduk
Copy link
Owner

No description provided.

@benpollarduk benpollarduk linked an issue Oct 31, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.37288% with 36 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (8dd5e8a) to head (69a2d77).

Files with missing lines Patch % Lines
NetAF/Logic/Arrangement/AssetArranger.cs 92.85% 2 Missing and 4 partials ⚠️
NetAF/Logic/PlayableCharacterLocation.cs 64.28% 5 Missing ⚠️
NetAF/Logic/Arrangement/RoomExitChange.cs 0.00% 4 Missing ⚠️
NetAF/Logic/Game.cs 88.46% 1 Missing and 2 partials ⚠️
NetAF/Serialization/Assets/RoomSerialization.cs 62.50% 0 Missing and 3 partials ⚠️
NetAF/Assets/Characters/Character.cs 88.88% 2 Missing ⚠️
NetAF/Assets/Interaction/InteractionResult.cs 75.00% 1 Missing and 1 partial ⚠️
...tAF/Serialization/Assets/OverworldSerialization.cs 66.66% 0 Missing and 2 partials ⚠️
NetAF/Serialization/Assets/RegionSerialization.cs 66.66% 0 Missing and 2 partials ⚠️
NetAF/Commands/Game/UseOn.cs 0.00% 1 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   83.86%   85.01%   +1.15%     
==========================================
  Files          97      121      +24     
  Lines        2838     3237     +399     
  Branches      460      527      +67     
==========================================
+ Hits         2380     2752     +372     
- Misses        293      303      +10     
- Partials      165      182      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 2, 2024

@benpollarduk benpollarduk merged commit bf73a57 into main Nov 2, 2024
2 checks passed
@benpollarduk benpollarduk deleted the serialization branch November 2, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistence and Serialization
2 participants