Fixed minor issue with regions not being pannable in all cases

benpollarduk · Nov 15, 2024 · 7ad2b96 · 7ad2b96
1 parent a7a9f78
commit 7ad2b96
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/NetAF.Tests/Logic/Modes/RegionMapMode_Tests.cs b/NetAF.Tests/Logic/Modes/RegionMapMode_Tests.cs
@@ -39,7 +39,7 @@ public void GivenPositionOutOfBounds_WhenPanToPosition_ThenReturnFalse()
         }
 
         [TestMethod]
-        public void GivenPositionInBounds_WhenPanToPosition_ThenReturnTrue()
+        public void GivenPositionInBoundsAndVisited_WhenPanToPosition_ThenReturnTrue()
         {
             RegionMaker regionMaker = new(string.Empty, string.Empty);
             Room room = new(string.Empty, string.Empty);
@@ -49,5 +49,35 @@ public void GivenPositionInBounds_WhenPanToPosition_ThenReturnTrue()
 
             Assert.IsTrue(result);
         }
+
+        [TestMethod]
+        public void GivenPositionInBoundsButNotVisited_WhenPanToPosition_ThenReturnFalse()
+        {
+            RegionMaker regionMaker = new(string.Empty, string.Empty);
+            Room room = new(string.Empty, string.Empty);
+            Room room2 = new(string.Empty, string.Empty);
+            regionMaker[0, 0, 0] = room;
+            regionMaker[1, 0, 0] = room2;
+
+            var result = RegionMapMode.CanPanToPosition(regionMaker.Make(), new Point3D(1, 0, 0));
+
+            Assert.IsFalse(result);
+        }
+
+        [TestMethod]
+        public void GivenPositionInBoundsButNotVisitedButRegionIsVisibleWithoutDiscovery_WhenPanToPosition_ThenReturnTrue()
+        {
+            RegionMaker regionMaker = new(string.Empty, string.Empty);
+            Room room = new(string.Empty, string.Empty);
+            Room room2 = new(string.Empty, string.Empty);
+            regionMaker[0, 0, 0] = room;
+            regionMaker[1, 0, 0] = room2;
+            var region = regionMaker.Make();
+            region.VisibleWithoutDiscovery = true;
+
+            var result = RegionMapMode.CanPanToPosition(region, new Point3D(1, 0, 0));
+
+            Assert.IsTrue(result);
+        }
     }
 }
diff --git a/NetAF/Logic/Modes/RegionMapMode.cs b/NetAF/Logic/Modes/RegionMapMode.cs
@@ -70,7 +70,7 @@ public static bool CanPanToPosition(Region region, Point3D position)
         {
             var matrix = region.ToMatrix();
             var room = matrix[position.X, position.Y, position.Z];
-            return room != null && room.HasBeenVisited;
+            return room != null && (room.HasBeenVisited || region.VisibleWithoutDiscovery);
         }
 
         #endregion