Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing prefillParallelism argument in redis.go newRedisPool function #78

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NoumanArshad83
Copy link

@NoumanArshad83 NoumanArshad83 commented Dec 17, 2019

There were major changes in see history. The changes on May 25th, 2019 broken goworker package. Added required parameter with default value ( default value 0 as defined in struct ) to fix the issue

This PR will fix an open issue #76

@NoumanArshad83
Copy link
Author

Hello @benmanns / @TheOrioli / @brockwood,
As I cannot add a Reviewer so could any one please help me to review code changes?
Many thanks

goworker.go Outdated
UseNumber bool
SkipTLSVerify bool
TLSCertPath string
prefillParallelism int

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to use camelCase here? In the README you are using PascalCase.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing, fixed it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to be able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants