Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the workers list #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gravis
Copy link
Contributor

@gravis gravis commented Jan 1, 2014

but don't expose workerFuncs

Philippe Lafoucrière added 2 commits January 1, 2014 21:36
but don't expose workerFuncs
@gravis
Copy link
Contributor Author

gravis commented Jan 1, 2014

I created this because I want to be able to test that my worker is registered.

@benmanns
Copy link
Owner

benmanns commented Jan 1, 2014

Thanks for the contribution. In what sort of use case are you testing that a worker is registered?

@gravis
Copy link
Contributor Author

gravis commented Jan 1, 2014

Exactly as in https://github.com/gravis/goworker/blob/47c41eee3d1697086b36351383677e4f67ab55a7/workers_test.go
I have tests for my workers, but if they're not registered, I will have runtime errors like:

1388601384386690670 [Critical] No worker for SomeJob in queue myQueue with args []

@gravis
Copy link
Contributor Author

gravis commented Jan 1, 2014

Globally, I would like to add more exported (public) methods like that, for example to provide runtime info of my workers through various interfaces (telnet, http, etc.).

@gravis
Copy link
Contributor Author

gravis commented Feb 6, 2014

Any news on this? (and the other issues, more generally)
thanks

skaurus referenced this pull request in skaurus/goworker Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants