fix: remove escape pagination keys and use double quote instead

benjamin658 · Feb 1, 2021 · dc75226 · dc75226
1 parent a074e13
commit dc75226
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -31,6 +31,7 @@ const queryBuilder = getConnection()
 
 const paginator = buildPaginator({
   entity: User,
+  paginationKeys: ['id'],
   query: {
     limit: 10,
     order: 'ASC',
@@ -71,6 +72,7 @@ interface Cursor {
 ```typescript
 const nextPaginator = buildPaginator({
   entity: User,
+  paginationKeys: ['id'],
   query: {
     limit: 10,
     order: 'ASC',
@@ -86,6 +88,7 @@ const { data, cursor } = await nextPaginator.paginate(queryBuilder);
 ```typescript
 const prevPaginator = buildPaginator({
   entity: User,
+  paginationKeys: ['id'],
   query: {
     limit: 10,
     order: 'ASC',

diff --git a/src/Paginator.ts b/src/Paginator.ts
@@ -132,8 +132,8 @@ export default class Paginator<Entity> {
     let query = '';
     this.paginationKeys.forEach((key) => {
       params[key] = cursors[key];
-      where.orWhere(`${query}${escape(this.alias)}.${escape(key)} ${operator} :${key}`, params);
-      query = `${query}${escape(this.alias)}.${escape(key)} = :${key} AND `;
+      where.orWhere(`${query}${escape(this.alias)}."${key}" ${operator} :${key}`, params);
+      query = `${query}${escape(this.alias)}."${key}" = :${key} AND `;
     });
   }