Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP support fit_intercept in remaining solvers #94

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

WIP support fit_intercept in remaining solvers #94

wants to merge 20 commits into from

Conversation

cassiofragadantas
Copy link
Contributor

@cassiofragadantas cassiofragadantas commented May 12, 2022 •
edited
Loading

List of solvers to add fit_intercept support:

  • Blitz
  • Cd (only dense)
  • Julia-PGD (only dense)
  • L-BFGS-B (only dense)
  • Lightning (only dense)
  • noncvx-pro (only dense)
  • Python-PGD (only dense)
  • R-PGD (only dense)
  • skglm (only dense)

Other:

  • spams: could not run (seg fault)

For some solvers, fit_intercept was added only for dense datasets (explicitly indicated above).

@cassiofragadantas cassiofragadantas changed the title ENH support fit_intercept in remaining solvers WIP support fit_intercept in remaining solvers May 12, 2022
@cassiofragadantas cassiofragadantas mentioned this pull request May 17, 2022
Open
@cassiofragadantas cassiofragadantas mentioned this pull request May 19, 2022
Open
@cassiofragadantas
Copy link
Contributor Author

CI still to be verified.

mathurinm
mathurinm requested changes Jul 13, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort left review comments

@tomMoral tomMoral tomMoral left review comments

@mathurinm mathurinm mathurinm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cassiofragadantas @agramfort @tomMoral @mathurinm