Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Install spams from correct, up to date PyPI package #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gdurif
Copy link

@gdurif gdurif commented Mar 11, 2022

spams will be installed using official repository.

mkl package is also required for better performance.

benchopt test benchmark_lasso is running on my machine (so far, so good).

@gdurif
Copy link
Author

gdurif commented Mar 11, 2022

Well... benchOpt/benchopt/tests/test_benchmarks.py::test_solver_install[benchmark_lasso-spams] FAILED

See also: getspams/spams-python#17 (thanks @mathurinm)

@mathurinm mathurinm changed the title fix spams solver requirements FIX Install spams from correct, up to date PyPI package Mar 11, 2022
@mathurinm
Copy link
Collaborator

I tried on my computer. I think it is related to the failures we are experiencing in #62 (linking failing during cython compilation). The issue is that on my machine it happens even with python 3.9, while for cd_solver I was able to fix by upgrading to python 3.9

@gdurif gdurif mentioned this pull request Mar 24, 2022
@gdurif
Copy link
Author

gdurif commented Apr 1, 2022

@mathurinm

Would that be a solution to implement inside benchopt a proper PyPI-to-conda package conversion and installation with:

conda skeleton pypi my_package
conda build my_package
conda install --use-local my_package

Source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants