-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements (see PR) #298
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! I like a lot of the intended functionality here and believe it could be useful to others if generalized for other setups. I've left some comments in-line.
If you'd like to see this PR forward, I'd also want to see tests added for any new functionality and it looks like PHPCS is throwing some style errors since I activated CI on this PR.
Hello, thanks for your feedback. I have fixed and answered your remarks above. About tests, do you have some in mind to start with? I certainly won't have time and skills to implement all. |
Hello,
Thanks for your plugin that was very useful to me for my Jekyll migration from WordPress.
I have made some customizations that may interest some other users:
Hope these little things can be useful
Thanks again for the plugin,