Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested main modules #164

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

Vakrim
Copy link

@Vakrim Vakrim commented Jan 23, 2021

Idea for this was presented in #163.

This PR adds option that allows to have module and its dependencies in the same folder.

❯ destiny --nest-main-modules
...
├── (login.js is moved from here)
└── login
    ├── login.js (and it's now here)
    └── search.js (at the same level with dependency)

You can see extended example in #163

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #164 (c57771d) into develop (3cfab83) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
+ Coverage    92.97%   93.25%   +0.27%     
===========================================
  Files           22       23       +1     
  Lines          598      608      +10     
  Branches       141      142       +1     
===========================================
+ Hits           556      567      +11     
+ Misses          42       41       -1     
Impacted Files Coverage Δ
src/index.ts 68.57% <100.00%> (+1.40%) ⬆️
src/index/generateTrees.ts 100.00% <100.00%> (ø)
src/index/generateTrees/toFractalTree.ts 89.62% <100.00%> (+2.95%) ⬆️
...c/index/generateTrees/toFractalTree/getFileName.ts 100.00% <100.00%> (ø)
src/index/formatFileStructure/moveFiles.ts 86.20% <0.00%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfab83...c57771d. Read the comment docs.

};

describe("end-to-end", () => {
function t(options: string[]) {
const uniqeDirName = randomBytes(8).toString("hex");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm creating new folder for each "describe", because previously one was affecting other and changing order of tests was causing changes in snapshots

@AnatoleLucet AnatoleLucet self-requested a review February 19, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant