Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new version of bem-tools-create #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use new version of bem-tools-create #13

wants to merge 2 commits into from

Conversation

veged
Copy link
Member

@veged veged commented Mar 25, 2017

Close #12

@awinogradov
Copy link
Member

@tadatuta can we already use bem-create by level templates?

@tadatuta
Copy link
Member

@awinogradov

can we already use bem-create by level templates?

not sure what are you asking about but this PR looks good to me

@awinogradov
Copy link
Member

awinogradov commented May 19, 2017 via email

@tadatuta
Copy link
Member

yes, it should work

@veged veged closed this Sep 1, 2017
@veged veged reopened this Sep 1, 2017
@veged
Copy link
Member Author

veged commented Sep 1, 2017

@tadatuta we fix templates and try to do bem create Test (which create all as suppose) and bem create -l blocks/Test/Test.tests simple (which do not create anything) — looks like 'blocks/**/*.tests' in .bemrc.js do not match and affect creation

@tadatuta
Copy link
Member

tadatuta commented Sep 1, 2017

@veged that's true 'coz current implementation of glob expansion uses glob module which looks for real folders on FS.

I created bem-tools/bem-tools-create#52 to support current case but can't say if it can be implemented soon.

Right now the only way to go is to create blocks/Test/Test.tests manually or add it as one of the block's tech (so that bem create Test call with create Test.{css,js,tests}).

@veged
Copy link
Member Author

veged commented Sep 4, 2017

@tadatuta actually there is the similar problem if directory blocks/Test/Test.tests already exists — bem create will create only default techs (not ones those configured for 'blocks/**/*.tests')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants