perf: add PooledHashSet and PooledStringBuilder#1550
Draft
TimothyMakkison wants to merge 1 commit intobelav:mainfrom
Draft
perf: add PooledHashSet and PooledStringBuilder#1550TimothyMakkison wants to merge 1 commit intobelav:mainfrom
PooledHashSet and PooledStringBuilder#1550TimothyMakkison wants to merge 1 commit intobelav:mainfrom
Conversation
4e8303f to
4d90a40
Compare
4d90a40 to
c5bfffd
Compare
Closed
eeaf247 to
9e9ad83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
PooledHashSetandPooledStringBuilder, I'm only using it forDocPrinter.OutputandPropagateBreaks.alreadyVisitedSetas they get to upwards of 50,000 items. I don't reuse very large objects to prevent cases where a massive file creates some large objects and they are never garbage collected, eating up space.I'll look into benchmarking this change with a real world large repo.
Are there any instances where csharpier is kept running for a long time? This change is beneficial for projects with lots of medium sized files but passively uses more memory. I'm a bit worried this will eat up 64 MB when using csharpier as an extension.
I can mitigate this with a cleanup function if needed.
Related
Benchmarks
Before
After