Add the license presence assertion (closes: #49)

If "License-File" is present in Metadata file, we can safely add the
`-l` flag to %pyproject_save_files. The flag asserts that at least
one license file is marked as %license in the %files section
when there are none specified manually.
Not all build backends expose the field yet, which was oficially added
to Core Metadata 2.4 with PEP 639.

README.md

@@ -121,6 +121,7 @@ Configuration data is stored in a TOML file.
 | archful | package contains compiled extensions, implies not using `BuildArch: noarch` and adding `BuildRequires: gcc` | bool |
 | python_alt_version | specific Python version to create the spec file for, e.g. 3.9, 3.10, 3.12 | string |
 | automode | create buildable spec files that don't have to fully comply with Fedora Guidelines; useful for automatic build environments | bool |
+| license_files_present | `License-File` field was detected in the package metadata | bool |
 
 
 ### Example config file generated by pyp2spec
@@ -139,6 +140,7 @@ archive_name = "aionotion"
 extras = []
 archful = false
 automode = false
+license_files_present = false
 ```
 
 ### Spec file generated using the example config

pyp2spec/conf2spec.py

@@ -120,6 +120,7 @@ def fill_in_template(config):
         extras=",".join(config.get_list("extras")),
         license=license,
         license_notice=license_notice,
+        mandate_license=config.get_bool("license_files_present"),
         name=config.get_string("pypi_name"),
         python_name=config.get_string("python_name"),
         pypi_version=config.get_string("pypi_version"),

pyp2spec/pyp2conf.py

@@ -1,4 +1,5 @@
 from functools import wraps
+import email.parser
 import re
 import sys
 
@@ -44,14 +45,15 @@ class PypiPackage:
     This is only relevant for testing.
     """
 
-    def __init__(self, package_name, *, version=None, package_metadata=None, session=None):
+    def __init__(self, package_name, *, version=None, package_metadata=None, metadata_from_file=None, session=None):
         self.package_name = package_name
         self._session = session or requests.Session()
         self.version = version or self._get_version_from_package_metadata()
         # package_metadata - custom dictionary with package metadata - used for testing
         # in the typical app run it's not set,
         # meaning we jump to the other sources package metadata data (eg. PyPI)
         self.package_data = package_metadata or self._get_package_version_metadata()
+        self.metadata_from_file = metadata_from_file or self.parse_metadata()
         self.sdist_filename = None
 
     @property
@@ -87,6 +89,20 @@ def _get_package_version_metadata(self):
         error_str = f"Package `{self.package_name}` or version `{self.version}` was not found on PyPI"
         return self._get_from_url(pkg_index, error_str)
 
+    def _get_metadata_file(self):
+        for entry in self.package_data["urls"]:
+            if entry["packagetype"] == "bdist_wheel":
+                response = self._session.get(entry["url"] + ".metadata")
+                if not response.ok:
+                    click.secho("The metadata file could not be located", fg="red")
+                    response.text = None
+                return response.text
+
+    def parse_metadata(self):
+        metadata = self._get_metadata_file()
+        parser = email.parser.Parser()
+        return parser.parsestr(metadata)
+
     def python_name(self, *, python_alt_version=None):
         """Create a component name for the specfile.
 
@@ -328,6 +344,9 @@ def extras(self):
                     extras.add(found.group(1))
         return sorted(extras)
 
+    def are_license_files_included(self):
+        return True if self.metadata_from_file.get_all("License-File") else False
+
 
 def get_description(package):
     """Return a default package description."""
@@ -404,6 +423,7 @@ def create_config_contents(
     contents["source"] = pkg.source()
     contents["archive_name"] = pkg.archive_name()
     contents["extras"] = pkg.extras()
+    contents["license_files_present"] = pkg.are_license_files_included()
 
     return contents
 

pyp2spec/template.spec

@@ -62,7 +62,7 @@ Summary:        %{summary}
 %pyproject_save_files '*' +auto
 {%- else -%}
 # Add top-level Python module names here as arguments, you can use globs
-%pyproject_save_files ...
+%pyproject_save_files{% if mandate_license %} -l{% endif %} ...
 {%- endif %}
 
 

tests/conftest.py

@@ -1,3 +1,4 @@
+import email.parser
 import json
 
 import betamax
@@ -17,3 +18,9 @@
 def fake_fedora_licenses():
     with open("tests/fedora_license_data.json", "r", encoding="utf-8") as f:
         return json.load(f)
+
+
+@pytest.fixture(scope="session")
+def fake_metadata_from_file():
+    # Return an object with fake metadata
+    return email.parser.Parser().parsestr("Name: foo")

tests/expected_specfiles/python-click.spec

@@ -1,5 +1,5 @@
 Name:           python-click
-Version:        7.1.2
+Version:        8.1.7
 Release:        %autorelease
 # Fill in the actual package summary to submit package to Fedora
 Summary:        Composable command line interface toolkit
@@ -41,7 +41,7 @@ Summary:        %{summary}
 %install
 %pyproject_install
 # Add top-level Python module names here as arguments, you can use globs
-%pyproject_save_files ...
+%pyproject_save_files -l ...
 
 
 %check

tests/expected_specfiles/python3.9-pello.spec

@@ -44,7 +44,7 @@ This is package 'Pello' generated automatically by pyp2spec.}
 %install
 %pyproject_install
 # Add top-level Python module names here as arguments, you can use globs
-%pyproject_save_files ...
+%pyproject_save_files -l ...
 
 
 %check