Conversation
test_invalid_app_version is removed because most strings are valid with the updated pattern.
|
Thanks for the PR, and the research into the underlying cause. There's a couple of hidden issues with the "replace the regex" approach you've taken here. Most notably, the full regex accepts It's also problematic to delete all the "invalid" test cases. While it's true that there are a lot of previously invalid version numbers that are now valid, there are still some invalid version numbers, and we would still need to validate those. However - I think the better approach is to go all-in on using |
The PEP 440 version regex used by Briefcase is outdated. The canonical format is now described in packaging.python.org and is provided by
packaging.Changes
PEP440_CANONICAL_VERSION_PATTERN_REto usepackaging.version.VERSION_PATTERN.test_invalid_app_versiontest since most strings are now valid versions according to the latest specification.PR Checklist:
Context
We're exploring using Briefcase for Anki and ran into an issue because Anki's calendar versioning scheme is not recognized by Briefcase:
ankitects/anki#4557