Add releasegroupdisambig MediaField #20
Conversation
There was a problem hiding this comment.
Looks good overall! I note that your MB ticket has generated some discussion:
https://tickets.metabrainz.org/browse/PICARD-1617
To confirm what you've mentioned elsewhere, is it true that Picard does not yet have a tag mapping for this? If so, maybe we should wait to come to consensus about the tag mapping and do this in concert with the Picard people.
| @@ -1843,6 +1843,14 @@ def update(self, dict): | |||
| StorageStyle('MUSICBRAINZ_ALBUMCOMMENT'), | |||
| ASFStorageStyle('MusicBrainz/Album Comment'), | |||
| ) | |||
| releasegroupdisambig = MediaField( | |||
| # This tag mapping was invented for beets (not used by Picard, etc). | |||
There was a problem hiding this comment.
Maybe just say "As above." or something instead of duplicating the text?
|
Yes, I’d actually like you and Philipp Wolfer maybe get in sync (you could jump in on PICARD-1617) so this can get sorted once and for all. Be it even that both should be changed back, because MusicBrainz’ rules about tag naming have apparently been changed. Of course, things have to start somewhere, so in this case I try to coordinate/make aware a little, because I think if we do it, it’s early enough to sync with other developers so users don’t experience uncontrollable tag proliferation. It would just be great if, say, beets, Picard, foobar2000 and Mp3tag would pick these up first, so that a large user base can be happy. |
|
See current discussion in PICARD-1617. @sampsyo: Do you think we should keep or change the |
|
Good question—sorry if I've lost track and the answer should be obvious, but what would we change them to? Are other tags in use by other software already? |
|
Just asking because MusicBrainz call those So I was thinking of maybe |
|
Got it; I see what you're saying. It would indeed be a little tricky to get right in a backwards-compatible way… and the data (at least for beets) does literally come from something called a "disambiguation string." So maybe it's defensible to just leave it how it is for now, unless we run into a scenario where "comments" aside from these disambiguation strings become an important thing? |
|
Ok, agreed. So let’s hope we get this tag naming thing finalized soon and proceed from there. |
As discussed in the forum, add a proposed
releasegroupdisambig("MusicBrainz Release Group Comment") media field.