Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python to current supported versions. Also add experimental support for next python release #5503

Closed
wants to merge 8 commits into from
Closed

Update python to current supported versions. Also add experimental support for next python release #5503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1314579
Drop Python 3.8 from the package, update dependencies
snejus Nov 17, 2024
ffd92b7
Update CI config, minimum ruff version, docs and add changelog note
snejus Nov 17, 2024
a578ee7
Use PEP585 lowercase collections typing annotations
snejus Nov 17, 2024
cf737de
Remove unnecessary quotes from types
snejus Nov 17, 2024
1fa6f07
Replace Union types by PEP604 pipe character
snejus Nov 17, 2024
85f1666
Update deprecated imports
snejus Nov 17, 2024
3e545a2
Move imports required for typing under the TYPE_CHECKING block
snejus Nov 22, 2024
75f2b85
Update python to current supported versions. Also add experimental su…
Fale Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,19 @@ jobs:
fail-fast: false
matrix:
platform: [ubuntu-latest, windows-latest]
python-version: ["3.8", "3.9"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
experimental: [false]
include:
- python-version: "3.13"
platform: ubuntu-latest
experimental: true
- python-version: "3.14-dev"
platform: ubuntu-latest
experimental: true
runs-on: ${{ matrix.platform }}
continue-on-error: ${{ matrix.experimental }}
env:
IS_MAIN_PYTHON: ${{ matrix.python-version == '3.8' && matrix.platform == 'ubuntu-latest' }}
IS_MAIN_PYTHON: ${{ matrix.python-version == '3.9' && matrix.platform == 'ubuntu-latest' }}
steps:
- uses: actions/checkout@v4
- name: Install Python tools
Expand All @@ -33,7 +42,7 @@ jobs:
if: matrix.platform == 'ubuntu-latest'
run: |
sudo apt update
sudo apt install ffmpeg gobject-introspection libgirepository1.0-dev
sudo apt install ffmpeg gobject-introspection libgirepository1.0-dev llvm libopenblas-dev
poetry install --extras=replaygain --extras=reflink

- name: Install Python dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- master

env:
PYTHON_VERSION: 3.8
PYTHON_VERSION: 3.9

jobs:
changed-files:
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
run: echo "::add-matcher::.github/sphinx-problem-matcher.json"

- name: Build docs
run: |
run: |-
poe docs |& tee /tmp/output
# fail the job if there are issues
grep -q " WARNING:" /tmp/output && exit 1 || exit 0
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@

repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.8.0
rev: v0.8.1
hooks:
- id: ruff-format
4 changes: 2 additions & 2 deletions CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ command. Instead, you can activate the virtual environment in your shell with::

$ poetry shell

You should see ``(beets-py38)`` prefix in your shell prompt. Now you can run
You should see ``(beets-py3.9)`` prefix in your shell prompt. Now you can run
commands directly, for example::

$ (beets-py38) pytest
$ (beets-py3.9) pytest

Additionally, `poethepoet`_ task runner assists us with the most common
operations. Formatting, linting, testing are defined as ``poe`` tasks in
Expand Down
3 changes: 2 additions & 1 deletion beets/autotag/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@

"""Facilities for automatically determining files' correct metadata."""

from typing import Mapping, Sequence, Union
from collections.abc import Mapping, Sequence
from typing import Union

from beets import config, logging
from beets.library import Album, Item
Expand Down
Loading
Loading