Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change zero documentation mentions of genre to genres #5486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheLastGimbus
Copy link

Description

I've spent 2 hours troubleshooting why none of my music had genre tag. It was because the single genre, without s doesn't seem to cover any good ganre tags... at least it didn't on my opus files

looking at the code: https://github.com/beetbox/mediafile/blob/7ecd86101ec3344e7fb25bbf781cd7f86646aa9d/mediafile.py#L1669-L2167 i don't honestly know why anyone created the single ganre field in the first place

To Do

  • Documentation. // Kinda...
  • Changelog. /// yeah, not really
  • Tests. // um....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant