Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit intent for firefox select element #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix exit intent for firefox select element #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92794a4
Work around Firefox bug: When clicking on a select element, clientX/c…
Feb 6, 2018
c6ac5ea
minify
Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions js/bioep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,10 @@ window.bioEp = {
// If this is an autocomplete element.
if(e.target.tagName.toLowerCase() == "input")
return;

// Firefox bug: When clicking on a select element, clientX/clientY becomes relative to the input. Ignore select elements.
if(e.target.tagName.toLowerCase() == "select")
return;

// Get the current viewport width.
var vpWidth = Math.max(document.documentElement.clientWidth, window.innerWidth || 0);
Expand Down
11 changes: 1 addition & 10 deletions js/bioep.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.