Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to close the popup on background click #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nleduc
Copy link

@nleduc nleduc commented Jul 31, 2017

I think some users expect an exit intent popup to close when the background is clicked and I believe it is a useful option to have.

I think some users expect an exit intent popup to close when the background is clicked and I believe it is a useful option to have.
@justinroodman
Copy link

Isn't this a more complicated way of achieving the same thing as noted here?

@nleduc
Copy link
Author

nleduc commented Aug 2, 2017

It's actually done the same way. I just made it a configurable option people can use rather than require them to add it to the code themselves.

@justinroodman
Copy link

Configurability is nice. Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants