Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync elixir versions, add usage section #40

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

jsegal205
Copy link
Contributor

Adds a section to the Readme about how to use this common config.

The tool-versions is on elixir 1.16, updates the common config to match that

https://github.com/beam-community/common-config/blob/main/templates/.tool-versions
https://github.com/beam-community/common-config/blob/main/templates/.github/workflows/common-config.yaml#L41

@jsegal205 jsegal205 requested a review from a team as a code owner October 21, 2024 16:27
Copy link
Member

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth mentioning that the template file escapes GHA variables, so people will need to search for $\{{ and replace it with ${{

@jsegal205
Copy link
Contributor Author

It's worth mentioning that the template file escapes GHA variables, so people will need to search for $\{{ and replace it with ${{

Good shout out @btkostner. Addressed with dbc2805

@btkostner btkostner added this pull request to the merge queue Oct 21, 2024
Merged via the queue into beam-community:main with commit fc51b8f Oct 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants