-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support named tuples and arrow serialization #41
Open
haberdashPI
wants to merge
15
commits into
main
Choose a base branch
from
dfl/onda-pirating
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−5
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7d4ee79
support named tuples, arrow serialization
haberdashPI d4efd81
use `Arrow.tobuffer`
haberdashPI 0425b3f
cleanup from review
haberdashPI 352b793
foramtting cleanup
haberdashPI 32cf866
fix arrow compat
haberdashPI 71adc6b
Fix inadvertently(?)/incorrectly removed space
ararslan dcd9092
Improve tuple documentation.
haberdashPI dfbeefa
add arrowtype compat
haberdashPI ac7e7e6
support more generic named tuples
haberdashPI d74d29e
Improved named tuple tests
haberdashPI b377cb3
error when start/stop are not `Period` types
haberdashPI 0f55ce4
Style fixes
ararslan fa817cb
NamedTuples must have Period start/stop
haberdashPI 4effcdd
istimespan on namedtuples
haberdashPI 74d7d40
switch to minor version bump
haberdashPI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
style = "yas" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,21 @@ | ||
name = "TimeSpans" | ||
uuid = "bb34ddd2-327f-4c4a-bfb0-c98fc494ece1" | ||
authors = ["Beacon Biosignals, Inc."] | ||
version = "0.3.1" | ||
version = "0.4.0" | ||
|
||
[deps] | ||
ArrowTypes = "31f734f8-188a-4ce0-8406-c8a06bd891cd" | ||
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a" | ||
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | ||
|
||
[compat] | ||
julia = "1.6" | ||
Arrow = "1.6" | ||
haberdashPI marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
[extras] | ||
Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45" | ||
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c" | ||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
||
[targets] | ||
test = ["Test"] | ||
test = ["Arrow", "Test", "Tables"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the slack conversation we do want to be careful about how this is introduced re the pirated methods removed in beacon-biosignals/Onda.jl#126