Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for ROS 2 release #10

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Prepare for ROS 2 release #10

merged 3 commits into from
Dec 3, 2024

Conversation

mhidalgo-bdai
Copy link

@mhidalgo-bdai mhidalgo-bdai commented Dec 2, 2024 •
edited
Loading

This patch applies the bare minimum changes prior to releasing (to avoid further diverging away from upstream). In particular:

  • It updates package maintainers.
  • It updates README files to:
    • Clearly state this is a fork
    • Ensure hyperlinks stay valid when scraped
  • It updates devcontainers
  • It adds a simple CI workflow

@mhidalgo-bdai
Update package maintainers
b4dcb83 
Signed-off-by: Michel Hidalgo <[email protected]>
@mhidalgo-bdai
Update READMEs
422634c 
Signed-off-by: Michel Hidalgo <[email protected]>
@mhidalgo-bdai mhidalgo-bdai self-assigned this Dec 2, 2024
@mhidalgo-bdai
Update CI and dev workflows
51eb094 
Signed-off-by: Michel Hidalgo <[email protected]>
tcappellari-bdai
tcappellari-bdai approved these changes Dec 3, 2024
View reviewed changes
Copy link

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhidalgo-bdai mhidalgo-bdai merged commit b487871 into ros2 Dec 3, 2024
1 check passed
@mhidalgo-bdai mhidalgo-bdai deleted the mhidalgo-bdai/prepare-for-release branch December 3, 2024 15:10
@mhidalgo-bdai mhidalgo-bdai mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcappellari-bdai tcappellari-bdai tcappellari-bdai approved these changes

@amessing-bdai amessing-bdai Awaiting requested review from amessing-bdai

@khughes-bdai khughes-bdai Awaiting requested review from khughes-bdai

Assignees

@mhidalgo-bdai mhidalgo-bdai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhidalgo-bdai @tcappellari-bdai