kindly review - Ravi Bhushan #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue details: When adding a new TODO, title text box does not get cleared similar to description. Solution: updated AddTodoForm.tsx - added value property to title input element to always shows value from the variable, which gets cleared after every submitting
Issue 2 details: Currently there are duplicate records shown in the list/grid.For instance TOODs with title "Implement user authentication" Issue 3 details: In "sampleData.json" there are around 8 TODO items but very few are getting displayed in UI Solution: updated index.tsx and fixed displayTodos function for "not urgent flow" was causing issue this behaviour and fix both issues
Issue 4 details: getting below warning during UI rendering "Warning: Each child in a list should have a unique "key" prop." Solution: added key attribute to TodoList.tsx, Key attribute helps React differentiate between elements in a list. When rendering a list of components, React uses the key to track each item and manage updates efficiently.
Issue 5 details: When adding new TODO, UI does not maintain state Solution: * added preventDefafult() in AddTodoForm.tsx to restrict browser to from refreshing/reloading UI * fixed AddTODO function in index.tsx file by adding new TODO object to the list in a way where react recognise/detect the state change
Issue 6 details: When deleting a completed TODO, all other TODOs also gets removed instead Solution: * updated deleteTodo condition in index.tsx to only remove intended TODO item
…deleted Issue 7 details: When a TODO gets completed or becomes not urgent , it gets removed from UI and earlier deleted TODOs gets displayed in UI Solution: * updated index.tsx callback function to Including todos ensures the callback always works with the latest state
Details: When a new TODO gets added,system is not providing any feedback to end user Solution: * Implemented toaster message on new TODOs - utilize react toastify dependency in package json and implemented toaster message in AddTodoForm.tsx to display a message on top right connor of UI to provide feedback to end user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Req 112704 - Written Assignment