Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarterly package updates #213

Merged
merged 17 commits into from
Dec 12, 2024
Merged

Quarterly package updates #213

merged 17 commits into from
Dec 12, 2024

Conversation

wilwong89
Copy link
Collaborator

@wilwong89 wilwong89 commented Dec 6, 2024

Description

Update node image to 22.12.0-alpine3.20
(Note: using alpine3.20 due to Prisma issue - prisma/prisma#25809)
Updated several packages on both frontend and backend.
Several packages needed to be pinned to a specific version due to incompatibility issues, dependency issues. To be resolved later as these packages resolve their issues.

For both backend and frontend, removed @tsconfig/node18 and replaced with @tsconfig/node20.

Backend pinned packages are:

  • date-fns

Frontend pinned packages are:

  • typescript
  • vite-plugin-vue-devtools
  • vue-tsc

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-297

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Dec 6, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.91% ( 1668 / 6697 )
Methods: 20.7% ( 236 / 1140 )
Lines: 29.58% ( 978 / 3306 )
Branches: 20.17% ( 454 / 2251 )

@wilwong89 wilwong89 force-pushed the chore/package-updates branch from 7a2c305 to 4a5d214 Compare December 6, 2024 02:09
Copy link

github-actions bot commented Dec 6, 2024

Coverage Report (Application)

Totals Coverage
Statements: 36.25% ( 1047 / 2888 )
Methods: 24.6% ( 123 / 500 )
Lines: 47.55% ( 698 / 1468 )
Branches: 24.57% ( 226 / 920 )

@wilwong89 wilwong89 closed this Dec 6, 2024
@wilwong89 wilwong89 reopened this Dec 6, 2024
Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies between major node versions need to be in lock step with each other. Please double check the dependency declarations and make sure we're either standardized to v20 or v22 across the board.

Dockerfile Outdated Show resolved Hide resolved
@jujaga jujaga self-requested a review December 7, 2024 02:08
@wilwong89 wilwong89 force-pushed the chore/package-updates branch 2 times, most recently from fb6bdf5 to b8dc290 Compare December 10, 2024 01:06
"volar-service-eslint": "^0.0.17",
"vue-tsc": "^2.1.6"
"vue-tsc": "~2.0.29"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like version has gone down, is this intentional? am I reading it wrong?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a temporary incompatibility between typescript and vue-tsc. There is a patch for vue-tsc that will resolve the issue next release. See this issue for details: vuejs/language-tools#5018

Backend packages updates:
Express, @tsconfig/node20

Backend packages pinned:
date-fns to 3.6.0

Frontend packages pinned:
typescript to 5.6.2
vite-plugin-vue-devtools to 7.6.5
vue-tsc to 2.0.29
@wilwong89 wilwong89 force-pushed the chore/package-updates branch from b8dc290 to a8f0557 Compare December 10, 2024 23:28
@kyle1morel kyle1morel merged commit 3e55efc into master Dec 12, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the chore/package-updates branch December 12, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants