Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial calendar implementation #29

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

TimaQT
Copy link

@TimaQT TimaQT commented Sep 25, 2024

Initial calendar setup completed, including the interface and fronted connection to the backend, along with a basic template for the assignment reader.

Note: The full integration with PCSS will come later (RESTful API and integration). The code structure may change depending on the API PCSS implementation. Features like Jump To Date, assignment displays inside the calendar cells and popups will also be added in the next phase.

Pull Request for JIRA Ticket: JASPER-71

Issue ticket number and link

https://jag.gov.bc.ca/jira/browse/JASPER-71

Description

Initial calendar setup completed, including the interface and fronted connection to the backend, along with a basic template for the assignment reader. The code structure may change depending on the API PCSS implementation.

Note: The full integration with PCSS will come later (RESTful API and integration). Features like Jump To Date, assignment displays inside the calendar cells and popups will also be added in the next phase.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual local testing for hard-coded assignments display
  • Unit tests will also be added in the next phase.

Checklist:

  • My code follows the style guidelines of this project

  • I have performed a self-review of my code

  • New and existing unit tests pass locally with my changes

  • Any dependent changes have been merged and published in downstream modules

  • I have commented my code, particularly in hard-to-understand areas. More comments would be added during further calendar development

  • There is a new warning within the calendar.js library - the warning does not affect the functionality, however it would be also investigated.

…d connection to the backend, along with a basic template for the assignment reader. The full integration with PCSS will come later. Features like Jump To Date, assignment displays inside the calendar cells and popups will also be added in the next phase.
@TimaQT TimaQT marked this pull request as draft September 25, 2024 22:00
Timaqt and others added 4 commits September 25, 2024 15:32
  - Calendar UI updated as per wireframes
  - Events were Added
  - Side panels behavior
  - Locations, Activities and Presiders Load
  - Events Filtering added
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.2% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@WadeBarnes
Copy link
Member

WadeBarnes commented Nov 5, 2024

@TimaQT, Have you reviewed the build errors here; https://github.com/bcgov/jasper/actions/runs/11672302245/job/32500602413?pr=29

Would you be able to provide some details on your local environment so we can determine what needs to be updated in the pipeline if needed?

Are you using the devContainer?
What versions of development tools and frameworks are you using? e.g. Node and npm versions. i.e. How does you're environment differ from the one defined in the main branch?
Please provide step by step instructions or how you're building the frontend for local testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants