Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON API support #734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ouranos
Copy link

@ouranos ouranos commented Dec 28, 2017

Add support for JSON API.

This makes hash_including works properly with JSON API requests.

Not sure if I need to change this part too?

I wasn't sure which specs to update, let me know if you need me to add anything else.

@bblimke
Copy link
Owner

bblimke commented Jan 3, 2018

@ouranos thank you!

If we add support for this then the failure output on non matching requests will be nicer, therefore I'd be keen to add support for that.

@ouranos
Copy link
Author

ouranos commented Jan 3, 2018

Ok, I'll add it then.

Any ideas why the specs are failing? It doesn't seem to be related to my changes.

@bblimke
Copy link
Owner

bblimke commented Jan 3, 2018

@ouranos please merge from master. I have fixed specs under jruby.

@ouranos
Copy link
Author

ouranos commented Jan 3, 2018

Rebased from master and added RequestSignature support. Let's see if the build pass.

@hoenic07
Copy link

hoenic07 commented Jun 7, 2018

This PR should fix the JSON API support, in a more generic way (and allows further content type customization): #763
Since JSON API is not that widely adopted yet, I wouldn't add it to the default content types.
Of course it would also be fine to have both solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants