Fix FrozenError in Typhoeus streaming response body #1078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stubbing a response for the Typhoeus adapter, and the Typhoeus request has an
on_body
callback, aFrozenError
exception is raised when attempting to concatenate the current chunk of the response to the existing response body (i.e.response.body << chunk
).FWIW, my use case for this is to abort a request as early as possible when the response body exceeds a given size, specifically when the response doesn't have a
Content-Length
header.The example below illustrates the issue:
This change initializes the Typhoeus response body to a non-frozen, mutable string when using the
on_body
callback.