Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the ArticlePage layout to enable full-width display for VJ scrolly components by removing the maximum width constraint and switching all articles to use the PGL (full-width) column layout.
Changes:
- Removed conditional column styling to always use full-width PGL column layout
- Disabled the secondary column sidebar for all article pages
- Changed grid max-width from a fixed pixel value to 100% to allow full-width content
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/pages/ArticlePage/ArticlePage.tsx | Switches to always use PGL column layout and comments out the secondary column |
| src/app/pages/ArticlePage/ArticlePage.styles.ts | Removes max-width constraint on the grid to enable full-width layout |
| <ElectionBanner aboutTags={aboutTags} taggings={taggings} /> | ||
| <div css={styles.grid}> | ||
| <div css={!isPGL ? styles.primaryColumn : styles.pglColumn}> | ||
| <div css={styles.pglColumn}> |
There was a problem hiding this comment.
The conditional logic for isPGL has been removed, forcing all articles to use the PGL column layout. This removes the ability to render articles in the standard column width. Consider whether this change should apply to all articles or only specific ones (e.g., those containing VJ scrolly components). If this is intended only for certain articles, restore the conditional logic.
| </div> | ||
| </div> | ||
| {!isApp && !isPGL && <SecondaryColumn pageData={pageData} />} | ||
| {/* {!isApp && !isPGL && <SecondaryColumn pageData={pageData} />} */} |
There was a problem hiding this comment.
The SecondaryColumn has been commented out rather than removed. If this is a permanent change, remove the commented code. If this is temporary for testing, add a comment explaining why it's commented out and when it should be restored.
| grid: ({ mq, gridWidths }: Theme) => | ||
| css({ | ||
| maxWidth: `${pixelsToRem(gridWidths[1008])}rem`, | ||
| maxWidth: '100%', |
There was a problem hiding this comment.
Changing the grid max-width to 100% affects all article pages globally. This may cause layout issues for standard articles that were designed for the constrained width. Consider making this change conditional based on article type or introducing a variant that only applies to VJ scrolly articles.
| maxWidth: '100%', | |
| maxWidth: `${gridWidths.default}px`, |
1 participant
http://localhost:7081/persian/articles/c356yy04502o?renderer_env=test