eager loading for first images on home and topics#12547
Merged
eagerterrier merged 13 commits intolatestfrom Apr 7, 2025
Merged
eager loading for first images on home and topics#12547eagerterrier merged 13 commits intolatestfrom
eagerterrier merged 13 commits intolatestfrom
Conversation
eagerterrier
changed the title
karinathomasbbc
approved these changes
Apr 7, 2025
src/integration/pages/homePage/arabic/__snapshots__/canonical.test.js.snap
Show resolved
Hide resolved
amoore108
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better to have eager rather than no loading directive, I think
also - homepages did not change lazy loading for top promo. This has been changed