WSTEAMA-1115 - A11y | Fix focus indicator VoiceOver bug on Homepage promos #12285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' of github.com:bbc/simorgh into WSTEAMA-1115-ally-fix-focus-indicator-on-homepage-promos
…s' of github.com:bbc/simorgh into WSTEAMA-1115-ally-fix-focus-indicator-on-homepage-promos
amoore108
reviewed
Jan 16, 2025
karinathomasbbc
approved these changes
Jan 16, 2025
amoore108
approved these changes
Jan 16, 2025
…s' of github.com:bbc/simorgh into WSTEAMA-1115-ally-fix-focus-indicator-on-homepage-promos
…s' of github.com:bbc/simorgh into WSTEAMA-1115-ally-fix-focus-indicator-on-homepage-promos
…s' of github.com:bbc/simorgh into WSTEAMA-1115-ally-fix-focus-indicator-on-homepage-promos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [1115]
Overall changes
Implementing a fix for a bug present on Homepage Promos in Safari whereby the screenreader does not announce content as expected when navigating through H3 elements using 'Ctrl + Opt + Right arrow key'. Through some investigation it was determined that the issue was coming from CSS styling being applied through our focus indicator. When the styling is applied directly to the Promo Link, the bug is no longer present.
A similar bug was also present on the Most Read component, so a similar fix has been implemented for this also.
Code changes
display: blockvalue applied to the Promo link to fix bug on promos using the Hierarchical Grid & CurationPromo components. Same value applied directly to the link CSS on the Billboard component.display: table-cellvalue applied directly to MostRead Item CSS and classname removed.Testing