1592 exit/closeVideo translations #12278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Matsika
commented
Jan 15, 2025
Louis-Matsika
commented
Jan 15, 2025
Louis-Matsika
commented
Jan 15, 2025
Co-authored-by: Karina Thomas <[email protected]>
…m/bbc/simorgh into 1592-exit/closeVideo-translations
emilysaffron
approved these changes
Jan 16, 2025
karinathomasbbc
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA 1592
Overall changes
Use available translations for 'Exit' in place of the standard hard coded 'Close video' translation.
Updated necessary config files within
/Users/matsil01/simorgh/src/app/lib/config/serviceswith new translationsTesting
LiveHeaderMediacloseButtonhas 'Salir' read out before the media descriptionNotes
*no translations for Somali right now
Helpful Links
Translations
Coding Standards
Repository use guidelines