Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSTEAM1-1343: Move Live Radio Data Fetching to BFF #12211

Merged
merged 37 commits into from
Dec 6, 2024
Merged

WSTEAM1-1343: Move Live Radio Data Fetching to BFF #12211

merged 37 commits into from
Dec 6, 2024

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Nov 26, 2024 •
edited
Loading

Resolves JIRA WSTEAM1-1343

Overall changes

Moves Live Radio page data fetching to the BFF

Code changes

  • Updates all Live Radio fixture data
  • Updates getInitialData for Live Radio to fetch from BFF
  • Allows toggle for Live Radio schedule to be passed into BFF fetch
  • Adds Live Radio page fetch url to be constructed to be fetched from fixture data locally
  • Updates ATIAnalytics and ChartbeatAnalytics to make use of new atiAnalytics field in the page metadata
  • Updates various components that were using the old MEDIA_PAGE page type const to LIVE_RADIO_PAGE
  • Updates unit/integration tests

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@HarveyPeachey HarveyPeachey self-assigned this Nov 26, 2024
@karinathomasbbc
Copy link
Contributor

karinathomasbbc commented Nov 27, 2024 •
edited
Loading

In order to fix the cypress tests, can we follow a similar pattern as OD TV - we don't need to go to the web-cdn to fetch the data - it's available on the window via cy.getPageDataFromWindow() - see https://github.com/bbc/simorgh/blob/WSTEAM1-1347-fetch-ondemand-podcast-from-bff/cypress/e2e/pages/onDemandAudio/tests.js#L16

This was a red herring - the tests were failing due to not being able to fetch local fixture data. This has now been resolved.

HarveyPeachey and others added 11 commits November 27, 2024 15:22
@HarveyPeachey HarveyPeachey changed the title migrates over getInitialData for live radio to bff WSTEAM1-1343: Move Live Radio Data Fetching to BFF Nov 29, 2024
@HarveyPeachey HarveyPeachey marked this pull request as ready for review December 2, 2024 09:49
karinathomasbbc
karinathomasbbc approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 📻

src/app/pages/LiveRadioPage/__snapshots__/index.test.tsx.snap Outdated Show resolved Hide resolved
Isabella-Mitchell
Isabella-Mitchell approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/app/routes/liveRadio/getInitialData/index.js Show resolved Hide resolved
src/app/routes/utils/constructPageFetchUrl/index.ts Outdated Show resolved Hide resolved
@HarveyPeachey HarveyPeachey merged commit 2e953c0 into latest Dec 6, 2024
11 checks passed
@HarveyPeachey HarveyPeachey deleted the WSTEAM1-1343-live-radio-bff-changes branch December 6, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@emilysaffron emilysaffron emilysaffron approved these changes

@Isabella-Mitchell Isabella-Mitchell Isabella-Mitchell approved these changes

Assignees

@HarveyPeachey HarveyPeachey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarveyPeachey @karinathomasbbc @emilysaffron @Isabella-Mitchell