WSTEAM1-1347 Move Podcast & On Demand Audio Data Fetching to BFF #12208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/legacy/containers/RadioSchedule/utilities/testHelpers.jsx
Outdated
Show resolved
Hide resolved
src/integration/pages/onDemandAudioPage/indonesia.expired/__snapshots__/canonical.test.js.snap
Show resolved
Hide resolved
src/integration/pages/onDemandAudioPage/pashtoBrand/__snapshots__/canonical.test.js.snap
Outdated
Show resolved
Hide resolved
src/integration/pages/onDemandAudioPage/pashtoBrand/__snapshots__/canonical.test.js.snap
Show resolved
Hide resolved
src/integration/pages/podcastPage/portugueseBrand/__snapshots__/canonical.test.js.snap
Outdated
Show resolved
Hide resolved
….com:bbc/simorgh into WSTEAM1-1347-fetch-ondemand-podcast-from-bff
…the pageData contentType (which is undefined since the refactor)
Isabella-Mitchell
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
👏 So much work here!
Looked over the links locally (e.g. http://localhost.bbc.com:7080/gahuza/podcasts/p07yh8hb/p0k4x0jm?renderer_env=live) and compared it to live. Looks good. Will test fully once approved 👍
HarveyPeachey
approved these changes
Nov 28, 2024
karinathomasbbc
deleted the
WSTEAM1-1347-fetch-ondemand-podcast-from-bff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1347
Overall changes
Fetch data from the BFF in getInitialData instead of calling ares and processing the data within simorgh
Code changes
Testing
Test plan is WIP ! 🚧
Make sure the following are all wokring as expected, can use the test environment to regression test against live.
Links for testing :
onDemandAudio brand: https://www.bbc.com/gahuza/bbc_gahuza_radio/programmes/p02pcb5c
onDemandAudio episode: https://www.bbc.com/gahuza/bbc_gahuza_radio/p0k1qjp9
podcast brand: https://www.bbc.com/gahuza/podcasts/p07yh8hb
podcast episode: https://www.bbc.com/gahuza/podcasts/p07yh8hb/p094vs2n
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines