Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BADGERS-245: [BREAKING] Remove windowType metadata #364

Draft
wants to merge 148 commits into
base: master
Choose a base branch
from
Draft

BADGERS-245: [BREAKING] Remove windowType metadata #364

wants to merge 148 commits into from

Conversation

eirikbjornr
Copy link
Contributor

@eirikbjornr eirikbjornr commented Jan 15, 2025 •
edited
Loading

📺 What

Remove BigscreenPlayer's reliance on windowType metadata. We've chosen to change the time representation for BigscreenPlayer with this change.

🛠 How

  • Replace "video time" with providing the "presentation time" from the media element. Provide conversion functions to availability and media sample times.
  • Add TimeShiftDetector to detect a sliding seekable range and activate auto-resume
  • Converted MediaSources to TypeScript

TODO:

  • Write a decision record on the new time representation
  • Write a decision record on the time shift detector
  • Write a short decision record for not estimating availabilityStartTime for HLS
  • Document that CEHTML does not support timeshift/simulcast
  • Update documentation to reflect the new API
  • Add documentation of the new time representation

eirikbjornr and others added 30 commits November 6, 2024 15:20
@eirikbjornr
refactor: drive dynamic utils off seekable range
3ca92e8
@matt-stephenson
rename manifestparser and test files from .js to .ts
89ee133
@matt-stephenson
feat: initial return of TimeInfo data from manifestparser, and fix up…
67b6329 
…p associated tests
@eirikbjornr
feat: add time converter
3f7e076
@eirikbjornr
refactor: promisify media sources (untested)
660d674
@eirikbjornr @matt-stephenson
test: source loading
adbac0f 
Co-authored-by: matt-stephenson <[email protected]>
@matt-stephenson
test: some mediaSources initialisation tests
3f10d52
@matt-stephenson
tests: add further assertions to media sources init tests
0a0e764
@eirikbjornr
test: media sources failovers
6c82d08
@matt-stephenson
tests: further cdn failover tests
30395d0
@eirikbjornr
test: failover with servicelocation
cb3aad7
@matt-stephenson
test: failover tests and refactoring of implementation
9c67ec5
@matt-stephenson
test: implement subtitle sources tests
f647dc3
@matt-stephenson
test: implement availableSources and refresh tests
dbee349
@matt-stephenson
test: implement reinstate cdn tests
7e2f6e8
@eirikbjornr
test: bigscreenplayer uses new media sources
0e28d3b
@matt-stephenson
test: endOfStream/liveEdge tests
751bef4
@matt-stephenson
test: update a bunch of bsp api tests to use new async initialisation…
8ffccd8 
… method
@matt-stephenson
test: implement canSeek and canPause tests
0f10233
@matt-stephenson
test: refactor end of stream tests. Add an additional one for pause a…
cbb284c 
…ction
@eirikbjornr
test: delete deprecated bsp methods
66667ef
@eirikbjornr
style: don't export transfer formats as single values
cd7f9ea
@matt-stephenson
test: first block of msestrategy tests. Including deletion of build_s…
82be21e 
…ource_anchor
@eirikbjornr
test: msestrategy getSeekableRange
4e1712f
@matt-stephenson
test: msestrategy getCurrentTime and getDuration
752341b
@matt-stephenson
test: msestrategy getPlayerElement
9eac39d
@matt-stephenson
test: WIP - rest tests
d030cce
@eirikbjornr
test: msestrategy setCurrentTime
fb95272
@matt-stephenson
test: auto-resume feature
2d9f893
@eirikbjornr
test: mse duration override
3b85b54
@eirikbjornr eirikbjornr added the semver major This PR is a semver major release label Jan 15, 2025
Luke-Chatburn
Luke-Chatburn reviewed Jan 22, 2025
View reviewed changes
src/dynamicwindowutils.ts Outdated
return liveSupport === LiveSupport.SEEKABLE || liveSupport === LiveSupport.RESTARTABLE
}

export function canSeek(liveSupport: LiveSupport, seekableRange: unknown): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe remove some duplication here and have "canPauseAndSeek" & "supportsPauseAndSeek" since they are doing the same thing.

You could still export different function names so you keep canSeek and canPause for consumption.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout!

Luke-Chatburn
Luke-Chatburn previously approved these changes Jan 22, 2025
View reviewed changes
jlks and others added 20 commits January 23, 2025 16:18
@jlks
handle MediaSources.time returning null, plain playback not having a …
bc9b502 
…mainfest to parse
@eirikbjornr
chore: rename manifestloader to sourceloader
48fb899
@eirikbjornr
test: loading plain sources
b6e6b6d
@eirikbjornr
chore: add types to sourceloader
9c07fa3
@eirikbjornr
chore: remove mimeType override
d38b9eb
@eirikbjornr
Revert "handle MediaSources.time returning null, plain playback not h…
bb7e7c4 
…aving a mainfest to parse"

This reverts commit bc9b502.
@jlks
update readyHelper to accept null as a valid seekableRange for playab…
6061dce 
…le/restartable
@jlks
fix: jest.fakeTimers setup and usage in mseStrategy
50f953b
@jlks
handle 0 start time in mse strategy the same as any other time
3c980cf
@eirikbjornr
feat: trace source loading
b541e55
@eirikbjornr
chore: ignore unbound method errors in test files
c73bf55
@eirikbjornr
style: merge canPause and canSeek
7d6fc35
@eirikbjornr
style: format existing decision records
ace3441
@eirikbjornr
docs: write decision record on time representation
33f9730
@eirikbjornr
docs: add decision record template
1bd237e
@eirikbjornr
feat: add decision record for fake seeking
bc5aade
@eirikbjornr
docs: decision record for timeshiftdetector
55506ae
@eirikbjornr
docs: decision record for HLS AST estimate
778ea03
@eirikbjornr
docs: all the tutorials
b6c7312
@eirikbjornr
docs: make em better
25ac3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Chatburn Luke-Chatburn Luke-Chatburn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jlks jlks

@eirikbjornr eirikbjornr

Labels
semver major This PR is a semver major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikbjornr @Luke-Chatburn @jlks @matt-stephenson