-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DVB Metrics Reporting #363
Open
ryanmccartney
wants to merge
26
commits into
bbc:master
Choose a base branch
from
ryanmccartney:dvb-metrics-reporting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dash subtitles
Add target-latency and current-latency to debug view
Plugin playback rate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Allows DASH manifests which specifies a metric reporting block in the following form;
to report to the endpoint.
🛠 How
Changes the Dash.js import to use
dashjs
instead ofindex_mediaplayerOnly
, additionally addssetXHRWithCredentialsForType("DVBReporting", true)
to allow cookies to be passed with any of these reporting requests by the place - this is required in order to ID the session.✅ Testing [Semi-optional]
Mock player expanded to include
setXHRWithCredentialsForType
method.Test Guidelines
Bundle size could change as a result of this PR.