rust_analyzer: make all paths in rust-project.json absolute #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards supporting automatic project discovery (bazelbuild#2755). Relative paths are resolved against the location of rust-project.json, but in auto-discovery this is the location of the BUILD file being discovered, not the workspace root. We already use absolute paths for generated files, so rust-project.json is not workspace-independent today. The alternatives seem more complex for little gain: - Only use absolute paths for auto-discovery mode, relative otherwise. - Use ../../ to express all workspace paths relative to the BUILD. See bazelbuild#2755 (comment)
krasimirgg
approved these changes
Dec 2, 2024
krasimirgg
reviewed
Dec 2, 2024
| output.nth(1).unwrap() | ||
| }) | ||
| .expect("Failed to find sysroot entry."); | ||
| // /tmp/_bazel/12345678/external/tools/rustlib/library => /tmp/bazel |
There was a problem hiding this comment.
shouldn't this be// ... => /tmp/_bazel?
|
@krasimirgg CI is broken, can you re-trigger or merge? EDIT: I can re-trigger myself, let's see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards supporting automatic project discovery (#2755).
Relative paths are resolved against the location of rust-project.json,
but in auto-discovery this is the location of the BUILD file being
discovered, not the workspace root.
We already use absolute paths for generated files, so rust-project.json
is not workspace-independent today.
The alternatives seem more complex for little gain:
See #2755 (comment)