Add support for strict associate deps #1260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber,
restingbull and
nkoroste
as code owners
|
We should add a readme section for this. |
Bencodes
commented
Jan 17, 2025
| @@ -39,7 +56,7 @@ def _get_associates(ctx, associates): | |||
| jars = [] | |||
| module_names = [] | |||
| for a in associates: | |||
| jars.append(depset(transitive = [a[JavaInfo].compile_jars, a[_KtJvmInfo].module_jars])) | |||
| jars.append(_collect_associates(ctx = ctx, toolchains = toolchains, associate = a)) | |||
There was a problem hiding this comment.
Unclear if the a[_KtJvmInfo].module_jars still needs to be included here. We don't hit this case in our codebase and I don't have enough historical context around why we need this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables support for strict Kotlin associate dependencies.
When
--@rules_kotlin//kotlin/settings:experimental_strict_associate_dependencies=Trueis enabled,rules_kotlinwill collect ONLY the directjava_output.compile_jarfor each given associate dependency, ensuring that only the Kotlin internals for the targets explicitly listed out as associates will be exposed.This behavior differs from what's currently in
rules_kotlinwhere it collects the entire transitive compile jars classpath for each associate dependency, which technically leaks the Kotlin internals of the entire classpath for each associate dependency.#1021