fix: env vars containing = #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
fix_env_split
branch
2 times, most recently
from
10ee2ea to
cdf0ea2
Compare
alexeagle
reviewed
Jun 7, 2024
| @@ -222,3 +222,30 @@ genrule( | |||
| ], | |||
| sha256 = "d7c7af5d86f43a885069408a89788f67f248e8124c682bb73936f33874e0611b", | |||
| ) | |||
|
|
|||
| http_file( | |||
There was a problem hiding this comment.
I should put rules_multitool in here as devdep
There was a problem hiding this comment.
that'd be great a follow-up
alexeagle
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where oci_image removed the content of env variables after first
=in the value. This fixes that issue and adds more tests to test against other cases.I added a nice assertion rule similar to
assert_tar_containswhich doesn't depend on a docker daemon and doesn't require a yaml file as a configuration language.(it was already somewhere in a branch, i just added it here so i can use it in the future.)