Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of incompatible_use_toolchain_transition. #446

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

katre
Copy link
Contributor

@katre katre commented Dec 19, 2023

Now that Bazel 7.0 has been released, it's time to remove this tech debt.

This has been a no-op since Bazel 5.0, I've been waiting to remove the code for two years, it's time.

Part of bazelbuild/bazel#14127.

Now that Bazel 7.0 has been released, it's time to remove this tech debt.

This has been a no-op since Bazel 5.0, I've been waiting to remove the code for
two years, it's time.

Part of bazelbuild/bazel#14127.
Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@katre
Copy link
Contributor Author

katre commented Dec 20, 2023

The test failure looks like a timeout. Does that block merging this PR?

@thesayyn thesayyn merged commit 1ba4cc1 into bazel-contrib:main Dec 20, 2023
15 of 16 checks passed
@katre katre deleted the remove-toolchain-transition branch December 20, 2023 16:23
@thesayyn
Copy link
Collaborator

The test failure looks like a timeout. Does that block merging this PR?

Not really. Its red on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants