-
Notifications
You must be signed in to change notification settings - Fork 241
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinking the sub directory should be disabled by default #1284
Comments
Merged
3 tasks
fffonion
changed the title
Symlinking the directory should be disabled by default
Symlinking the sub directory should be disabled by default
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a regression of #983, directories in a repository
is symlinked by default. This is IMO not the correct behaviour as it will cause the object file and target
file to generate in the original repsitory folder, if the build system is a simple
make
orconfigure_make
that generates file in place. The respository is supposed to not get changed after analysis phase otherwise
it's no longer hermetic.
Assume I have a project, in the repository, something like
execroot/_main/external/myrepo
in path:After the mentioned PR, in
BUILD_TMPDIR
we will have (something likeexternal/myrepo/myproject.build_tmpdir
in path):After this PR we end up writing
main.o
andmain
back toexecroot/_main/external/myrepo/src
.This will further cause problem if a target are required to compile in both exec and target configuration,
a race condition will happen to create either artifacts with exec or target configuration, or fail the build
completely.
The text was updated successfully, but these errors were encountered: