-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): bump Bazel from 6.x to 7.x and rules_foreign_cc from 0.9.0 to 0.12.0 #13603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Sep 2, 2024
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
2 times, most recently
from
September 2, 2024 09:04
d05926c
to
d3cfa7c
Compare
bungle
approved these changes
Sep 3, 2024
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
2 times, most recently
from
September 4, 2024 09:23
9908414
to
3bbec14
Compare
oowl
approved these changes
Sep 5, 2024
fffonion
changed the title
chore(deps): bump Bazel from 6.x to 7.x and rules_foreign_cc from 0.9.0 to 0.12.0
chore(build): bump Bazel from 6.x to 7.x and rules_foreign_cc from 0.9.0 to 0.12.0
Sep 10, 2024
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
5 times, most recently
from
September 10, 2024 15:33
6b70e95
to
aad4f41
Compare
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Sep 10, 2024
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
5 times, most recently
from
September 10, 2024 20:18
754e028
to
e1f80db
Compare
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
2 times, most recently
from
September 11, 2024 01:04
0f83b5d
to
70bcec3
Compare
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
2 times, most recently
from
September 11, 2024 03:16
16440bb
to
d118da1
Compare
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
from
September 11, 2024 03:29
d118da1
to
2cf5d64
Compare
Water-Melon
approved these changes
Sep 11, 2024
ADD-SP
approved these changes
Sep 11, 2024
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
2 times, most recently
from
September 11, 2024 09:49
aaf73c0
to
540699f
Compare
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
2 times, most recently
from
September 11, 2024 10:51
2ee9352
to
35fa37c
Compare
fffonion
force-pushed
the
bump-bazel-rules-foreign-cc
branch
from
September 11, 2024 10:55
35fa37c
to
5a07a65
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13603-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13603-to-master-to-upstream
git checkout -b cherry-pick-13603-to-master-to-upstream
ancref=$(git merge-base c498f41dc03f7a04aaf3df24c59e01ff5e39c339 5a07a655fe27faf6a1003183b4dfefac847d56cc)
git cherry-pick -x $ancref..5a07a655fe27faf6a1003183b4dfefac847d56cc |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 11, 2024
EE manual cherrypick at https://github.com/Kong/kong-ee/pull/10226 |
AndyZhang0707
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 24, 2024
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
core/docs
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some noticable changes:
@@label
to indicate a globally unique label.$$VAR
instead of$$VAR$$
bazel-bin
directory under workspace root is only populated after build complete (success or failure) so it's not accessible during build time. So we now use relative path instead (it's still safe as execroot is determinted).Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4445