Clarify SRI checksum needed by archive_override() #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zifeitong
requested review from
cloudhan,
jsharpe and
ryanleary
as code owners
zifeitong
changed the title
|
I actually wonder if https://www.w3.org/TR/SRI/ is the more canonical URL for subresource integrity; the bazel docs don't link anywhere when using this term and assume that you know that it is the same format used for web dev. |
|
Changed the URL to w3.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hexadecimal string of checksum, The SRI value must be in the format like
sha256-{base64(checksum)}. mdn.io/sri#tools_for_generating_sri_hashes shows a few ways to generate the SRI values.