fetch_repo: also remove WORKSPACE and MODULE files when cleaning #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not against this change if it helps, but the contents of all these files should be ignored by Bazel in the context of Gazelle-generated repos. Could you describe a concrete situation in which this was needed? |
yeah apologies for filing and running- this seemed to be necessary when dealing with a go dep pulled in via bzlmod rules_go that itself had a non-working MODULE.bazel at its root, but the errors i was seeing may well have been something else, i didn't make a strict test case. marking as draft for the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
go_repository
What does this PR do? Why is it needed?
Sometimes it's not just build files in go modules that are trouble, but inconveniently constructed MODULE.bazel files in repositories you'd like to pinch some go code from can also ruin your day. This does away with them, as well as WORKSPACE files for good measure.
Which issues(s) does this PR fix?
Other notes for review